Améliorations mineures #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tut-tuuut
reviewed
Nov 28, 2023
| badge = BadgeBlock(label="Badge") | ||
|
|
||
|
|
||
| heading_choices = [ |
There was a problem hiding this comment.
Ça m'embête un peu, ces variables qui se promènent entre deux définitions de classe. Y a-t-il moyen de les définir directement dans leurs classes ?
Un peu comme dans Django quand on a des CharField avec des choix :
class Student(models.Model):
class YearInSchool(models.TextChoices):
FRESHMAN = "FR", _("Freshman")
SOPHOMORE = "SO", _("Sophomore")
JUNIOR = "JR", _("Junior")
SENIOR = "SR", _("Senior")
GRADUATE = "GR", _("Graduate")
year_in_school = models.CharField(
max_length=2,
choices=YearInSchool.choices,
default=YearInSchool.FRESHMAN,
)There was a problem hiding this comment.
Ça m'embête aussi un peu, je les ai laissées avant leur classe (comme elles étaient quand j'ai déplacé le tout depuis models.py), mais je serai effectivement d'avis de soi les intégrer dans la classe, soit les déplacer dans un constants.py
tut-tuuut
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
🔍 Implémentation
dashboarddédiée à personnaliser l’admin de Wagtailwagtail.contrib.modeladminpar le paquetwagtail-modeladmin(provoquait unRemovedInWagtail60Warning)heading_tagau block callout pour résoudre une alerte d’accessibilitéCartes laissées en attente d’infos supplémentaires :
À faire dans une PR dédiée :
Issues concernant la section promotionnelle :
🏕 Amélioration continue
models.pyvers unblocks.pydédié.🖼️ Images
(optionnel) Une ou plusieurs captures d’écran, si pertinent